Answer "nothing to check" before "the tool is missing" - #2750
Merged
Conversation
#2746 put the compiler requirement first, so an empty tree got check_seal_coverage: the compiler is not built which is true and is not the diagnosis. With no seals there is nothing to recompute, and the answer the file already had is the right one: FAIL: no seals found at all -- the path is wrong, not the tree check_gate_preconditions.py hands every gate in its table an empty tree and asks what it says. It caught this on the commit after #2746 -- a gate doing exactly its job, one merge after I added a way for this one to lie. Controls, all re-run: empty tree -> exit 1, "no seals found at all" gen_hash corrupted -> exit 1, gen-drift compiler absent -> exit 2, says so clean tree -> exit 0 --self-check -> exit 0 check_gate_preconditions.py and its --self-check -> exit 0 Refs #2161 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Refs #2161 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
PR DashboardGenerated at: 2026-08-28 01:05:14 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2161
#2746 put the compiler requirement ahead of the empty-tree check, so a tree with no seals answered
which is true, and is not the diagnosis. With no seals there is nothing to recompute, and the file already had the right answer:
FAIL: no seals found at all -- the path is wrong, not the tree.check_gate_preconditions.pyhands every gate in its table an empty tree and asks what it says. It caught this on the commit after #2746 — the loud-failure gate doing exactly its job, one merge after I gave this one a way to lie.Controls
🤖 Generated with Claude Code